Fix logical error in path validation for SD file handling #1113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Thank you, indeed and looks like there is same issue with local FS handler orz.... do you mind to update your PR fixing it ? |
Contributor
Author
|
Please hold this PR for now. I will also include an update to 'esp3d/src/modules/http/handlers/handle-files.cpp' |
Contributor
Author
|
@luc-github, the PR has been updated and is ready for review |
Owner
|
@all-contributors please add @BerranRemzi for bug report and code fix |
Contributor
|
I've put up a pull request to add @BerranRemzi! 🎉 |
Owner
|
@BerranRemzi thank you so much - seems there for a while |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes a bug in the
handleSDFileListmethod inhandle-SD-files.cppby correcting the conditional check for a trailing slash in thepathvariable. The change replaces an assignment operator (=) with the correct equality operator (==), ensuring proper path handling. Without this fix, subfolders cannot be opened, and only the top-level directory of the SD card is visible.